Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Nov 5, 2019

Description

LG language server protocol (LSP) implementation for composer.

inline editor enhance

for inline editing, we no longer hideArea in editor, we put partial code on client, and the rest on language server, validation/completion/hover.. will be calculated from a combination file cross client and server.

Task Item

closes #1485
closes #1635
closed #1628
closed #1482

Type of change

Please delete options that are not relevant.

  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

preview

preview

Shuai Wang and others added 30 commits September 26, 2019 10:49
@zhixzhan
Copy link
Contributor Author

@zhixzhan Found one issue with the syntax highlighting,

in inline mode, the structured lg isn't highlighted
image

but in all up view, it works well
image

can you check with @cosmicshuai again?

ok I will take a look

boydc2014
boydc2014 previously approved these changes Nov 28, 2019
@boydc2014
Copy link
Contributor

Looks good to me now, @cwhitten @a-b-r-o-w-n can you help take a look again?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants